chore: fix missing setuptools in CI#3189
Merged
milas merged 1 commit intodocker:mainfrom Nov 27, 2023
Merged
Conversation
Install `setuptools` in addition to `wheel` before trying to run `python setup.py` manually. Note that `setuptools` is already correctly listed in the `pyproject.toml` file for consumers installing via `pip` etc, but in CI the file is run directly to generate `sdist` and `bdist_wheel` artifacts for PyPI. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
glours
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install
setuptoolsin addition towheelbefore trying to runpython setup.pymanually.Note that
setuptoolsis already correctly listed in thepyproject.tomlfile for consumers installing viapipetc, but in CI the file is run directly to generatesdistandbdist_wheelartifacts for PyPI.See failing CI log here: https://github.com/docker/docker-py/actions/runs/6947629399/job/18901833765