Skip to content

integration: Remove test_create_check_duplicate#3170

Merged
milas merged 1 commit intodocker:mainfrom
akerouanton:remove-test_create_check_duplicate
Aug 21, 2023
Merged

integration: Remove test_create_check_duplicate#3170
milas merged 1 commit intodocker:mainfrom
akerouanton:remove-test_create_check_duplicate

Conversation

@akerouanton
Copy link
Copy Markdown
Member

@akerouanton akerouanton commented Aug 19, 2023

moby/moby#46251 marks CheckDuplicate as deprecated. Any NetworkCreate request with a conflicting network name will now return an error.

@akerouanton
Copy link
Copy Markdown
Member Author

akerouanton commented Aug 19, 2023

@milas PTAL 🤗

thaJeztah
thaJeztah reviewed Aug 19, 2023
View reviewed changes
@akerouanton akerouanton force-pushed the remove-test_create_check_duplicate branch from 3d4b895 to ea48e4b Compare August 19, 2023 12:56
@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 19, 2023 

AttachContainerTest.test_attach_no_stream ___________________
tests/integration/api_container_test.py:1299: in test_attach_no_stream
    assert output == 'hello\n'.encode(encoding='ascii')
E   AssertionError: assert b'' == b'hello\n'
E     Use -v to get more diff
___________________ TestNetworks.test_create_check_duplicate ___________________
tests/integration/api_network_test.py:330: in test_create_check_duplicate
    self.tmp_networks.append(net_id['Id'])
E   TypeError: string indices must be integers

Ha! Wondering if the last failure is an implicit type conversion; if the network ID could be parsed as a hexadecimal🤔

Let me try restarting CI

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Aug 19, 2023

Although it failed in 2 check, so perhaps that line needs to be removed (and was only needed for the second test?)

@akerouanton akerouanton force-pushed the remove-test_create_check_duplicate branch from ea48e4b to 92c714a Compare August 19, 2023 13:57
@akerouanton
integration: check_duplicate is now the default behavior
6eddc0a 
moby/moby#46251 marks CheckDuplicate as deprecated. Any NetworkCreate
request with a conflicting network name will now return an error.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
@akerouanton akerouanton force-pushed the remove-test_create_check_duplicate branch from 92c714a to 6eddc0a Compare August 19, 2023 14:00
thaJeztah
thaJeztah approved these changes Aug 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@milas PTAL

@milas milas merged commit c38656d into docker:main Aug 21, 2023
@akerouanton akerouanton deleted the remove-test_create_check_duplicate branch August 21, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

+1 more reviewer

@milas milas milas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akerouanton @thaJeztah @milas