api: update return type of diff method#3115
Merged
milas merged 2 commits intodocker:mainfrom May 5, 2023
john-b-yang:main
Merged
api: update return type of diff method#3115milas merged 2 commits intodocker:mainfrom john-b-yang:main
diff method#3115milas merged 2 commits intodocker:mainfrom
john-b-yang:main
Conversation
Contributor
|
Thanks for the PR! Before I can accept this, I'll need you to make sure your commit has the Developer Certificate of Origin. See the instructions from CI @ https://github.com/docker/docker-py/pull/3115/checks?check_run_id=13126251061 |
Signed-off-by: John Yang <john.yang20@berkeley.edu>
Contributor
Author
|
@milas No problem and thanks for instructions! I believe I have made sure to include signoff on the editing commit. Happy to follow up on anything else that might be needed. |
milas
approved these changes
May 5, 2023
Contributor
|
All set! Thanks for the PR 👍🏻 |
Contributor
Author
|
No problem! Thanks so much for maintaining the tool, it has been super helpful for some things I'm working on of late, really appreciate it 🙏🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor fix, updating the documentation for the return type of the
diffmethod for the Container model.