Make dockerpycreds part of the SDK under docker.credentials#2222
Merged
Make dockerpycreds part of the SDK under docker.credentials#2222
Conversation
|
Please sign your commits following these rules: $ git clone -b "vendor_dockerpycreds" git@github.com:docker/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842359069392
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
9ccd3f4 to
e3787bb
Compare
chris-crone
approved these changes
Apr 15, 2019
Member
chris-crone
left a comment
There was a problem hiding this comment.
LGTM
Thanks @shin-. We should mark on the docker py creds repo as no longer maintained and point people here.
thaJeztah
reviewed
Apr 17, 2019
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
e3787bb to
4c45067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.