-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Provide a testable Dockerfile or image to run integration tests in Moby CI #2310
Copy link
Copy link
Open
Description
First; is there a Dockerfile in this repository that would be suitable to run the integration tests? And/or is such an image pushed to docker hub somewhere (or could it be?)
Basically; we run the docker-py tests on moby pull requests, but that currently means we also build docker-py, and have to install all its dependencies in the Dockerfile / dev-image (also see moby/moby#38526)
Given that;
- dependencies may change
- perhaps we want to run CI against multiple versions (different docker-py releases)
- nobody thinks of updating the
docker-pyin the tests at https://github.com/moby/moby ( unless something breaks), and when updating, it's hoping that it's just "change the version", and no dependency changes
I think all that the docker-py integration tests need is:
- a running daemon
- access to the daemon (docker-socket? or does it work better over http?)
- a docker-cli in the test-image (?)
If so, we could just
- pull a pre-built version of that image
- or build a Dockerfile from the
docker-pyrepo
- or build a Dockerfile from the
- start a daemon (built from the PR to test against those changes)
- run the image with
-v /var/run/docker.sock:/var/run/docker.sock - and run the tests (default entrypoint of the image, or e.g.
make test)
Correct?
My goal is to save some time building the Moby Dockerfile, but also to decouple the projects (i.e. don't require knowledge about what dependencies are needed, and how to build/install docker-py)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels