Handle inlay hint requests asynchronously #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlay hints on Dockerfiles need to fetch data so it can take some time before the result can be returned. This means that everything else gets blocked because all JSON-RPC messages are being handled synchronously at the moment. To alleviate this problem, we will check for inlay hint requests and then handle them in a goroutine asynchronously so that other messages can continue to be processed. Other messages may be changed to be handled asynchronously in the future but only inlay hint requests will be done this way for the time being. We want to be careful about introducing drastic changes to how messages are being handled as it is critical for the operation of the language server. Signed-off-by: Remy Suen <remy.suen@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlay hints on Dockerfiles need to fetch data so it can take some time before the result can be returned. This means that everything else gets blocked because all JSON-RPC messages are being handled synchronously at the moment. To alleviate this problem, we will check for inlay hint requests and then handle them in a goroutine asynchronously so that other messages can continue to be processed.
Other messages may be changed to be handled asynchronously in the future but only inlay hint requests will be done this way for the time being. We want to be careful about introducing drastic changes to how messages are being handled as it is critical for the operation of the language server.
Fixes #467.