Skip to content

Highlights and renames should not be triggered for bind mounts #450

@rcjsuen

Description

@rcjsuen

We should not be returning results for if the cursor is in ./folder given that it is not a volume object reference.

services:
  test:
    volumes:
      - ./folder:/mount

textDocument/documentHighlight:

{
    "textDocument": {
        "uri": "file:///Users/rcjsuen/tmp/empty/compose.yaml"
    },
    "position": {
        "line": 3,
        "character": 13
    }
}
[
    {
        "range": {
            "start": {
                "line": 3,
                "character": 8
            },
            "end": {
                "line": 3,
                "character": 16
            }
        },
        "kind": 2
    }
]

textDocument/prepareRename:

{
    "textDocument": {
        "uri": "file:///Users/rcjsuen/tmp/empty/compose.yaml"
    },
    "position": {
        "line": 3,
        "character": 13
    }
}
{
    "start": {
        "line": 3,
        "character": 8
    },
    "end": {
        "line": 3,
        "character": 16
    }
}

textDocument/rename:

{
    "textDocument": {
        "uri": "file:///Users/rcjsuen/tmp/empty/compose.yaml"
    },
    "position": {
        "line": 3,
        "character": 13
    },
    "newName": "./folder2"
}
{
    "changes": {
        "file:///Users/rcjsuen/tmp/empty/compose.yaml": [
            {
                "range": {
                    "start": {
                        "line": 3,
                        "character": 8
                    },
                    "end": {
                        "line": 3,
                        "character": 16
                    }
                },
                "newText": "./folder2"
            }
        ]
    }
}

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions