Skip to content

Document link calculation assumes service images are valid #306

@rcjsuen

Description

@rcjsuen

Compose files can just have a registry without anything after it so we need to protect against these cases.

services:
  test:
    image: mcr.microsoft.com
runtime.boundsError runtime error: slice bounds out of range [18:17] 
    /home/runner/work/docker-language-server/docker-language-server/internal/pkg/server/server.go:218 (*Server).handleRecovered
    /home/runner/work/docker-language-server/docker-language-server/internal/pkg/server/server.go:131 NewServer.func1
    /home/runner/work/docker-language-server/docker-language-server/internal/tliron/glsp/protocol/handler.go:100 (*Handler).Handle.func1
    runtime/panic.go:792 gopanic
    runtime/panic.go:155 goPanicSliceB
    /home/runner/work/docker-language-server/docker-language-server/internal/compose/documentLink.go:235 extractImageLink
    /home/runner/work/docker-language-server/docker-language-server/internal/compose/documentLink.go:83 createImageLink
    /home/runner/work/docker-language-server/docker-language-server/internal/compose/documentLink.go:156 scanForLinks
    /home/runner/work/docker-language-server/docker-language-server/internal/compose/documentLink.go:216 DocumentLink
    /home/runner/work/docker-language-server/docker-language-server/internal/pkg/server/documentLink.go:22 (*Server).TextDocumentDocumentLink
    /home/runner/work/docker-language-server/docker-language-server/internal/tliron/glsp/protocol/handler.go:538 (*Handler).Handle
    /home/runner/work/docker-language-server/docker-language-server/internal/tliron/glsp/server/handler.go:48 (*Server).handle
    github.com/sourcegraph/jsonrpc2@v0.2.0/handler_with_error.go:21 (*HandlerWithErrorConfigurer).Handle
    github.com/sourcegraph/jsonrpc2@v0.2.0/conn.go:205 (*Conn).readMessages

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions