Dockerfile: document build-args#412
Merged
Merged
Conversation
thaJeztah
commented
Mar 5, 2026
Comment on lines
+24
to
26
| # It sets the "github.com/docker/docker-credential-helpers/credentials.Package | ||
| # variable at compile time. | ||
| ARG PACKAGE=github.com/docker/docker-credential-helpers |
Member
Author
There was a problem hiding this comment.
FWIW; it's really unfortunate that it doesn't allow an empty line between; i.e., this doesn't work (doesn't show up in outline);
# PACKAGE sets the package name to print in the "--version" output.
#
# It sets the "github.com/docker/docker-credential-helpers/credentials.Package
# variable at compile time.
ARG PACKAGE=github.com/docker/docker-credential-helpersWondering if we should allow that; would that be possible? cc @crazy-max
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
``` docker buildx build --quiet --call=outline . BUILD ARG VALUE DESCRIPTION GO_VERSION 1.25.8 sets the version of the golang base image to use. BASE_DEBIAN_DISTRO bookworm sets the golang base image debian variant to use. XX_VERSION 1.7.0 sets the version of the xx utility to use. OSXCROSS_VERSION 11.3-r8-debian sets the MacOSX cross toolchain to use. PACKAGE github.com/docker/docker-credential-helpers sets the package name to print in the "--version" output. ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
5975365 to
6fe9815
Compare
Member
Author
|
@vvoland @crazy-max PTAL |
This was referenced Apr 17, 2026
Merged
vvoland
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)