rootless-extras: add passt as an alternative to slirp4netns#1276
rootless-extras: add passt as an alternative to slirp4netns#1276vvoland merged 1 commit intodocker:masterfrom
Conversation
0ffddc5 to
58d48cd
Compare
vvoland
left a comment
There was a problem hiding this comment.
passt change LGTM, but some comment on the nftables
rpm/SPECS/docker-ce.spec
Outdated
| Recommends: (iptables-nft or iptables) | ||
| Requires: nftables |
There was a problem hiding this comment.
Hmm shouldn't it be the reverse?
| Recommends: (iptables-nft or iptables) | |
| Requires: nftables | |
| Requires: (iptables-nft or iptables) | |
| Recommends: nftables |
By default we still use iptables while nftables is experimental opt-in, right?
So the package requires the iptables interface, but may work with nftables (if explicitly configured)
There was a problem hiding this comment.
Oh, thank you - I've put iptables back to Requires.
(I was experimenting on RHEL 10, where the iptables packages aren't easily available - Recommends makes Docker installable without access to the restricted repos, which is fine if it's then run with nftables or iptables disabled, and Recommends is still stronger than Suggests. But, hadn't finished the thought, it wasn't meant for this PR - it's probably too likely to break install scripts that use --no-install-recommends.)
Signed-off-by: Rob Murray <rob.murray@docker.com>
58d48cd to
237e492
Compare
- What I did
pastadriver detection moby/moby#51143In deb/rpm specs - recommend/require
passtas an alternative toslirp4netns. (RHEL 10 deprecatesslirp4netns.)- Description for the changelog