test(mcp): fix staticcheck SA5011 nil-pointer errors in oauth_test#2989
Merged
Conversation
docker-agent
reviewed
Jun 3, 2026
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR is a clean, targeted lint fix. The three if got == nil { t.Fatal(...) } guards are replaced with semantically equivalent require.NotNil(t, got, ...) calls from testify. Since require.NotNil calls t.FailNow() internally, the fail-fast behavior is preserved. No logic changes, no new control-flow paths, no resource management issues, and no security implications. The fix correctly resolves the staticcheck SA5011 false positives.
No bugs found in the changed code.
rumpl
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main branch CI was failing with 6 golangci-lint staticcheck SA5011 ("possible nil pointer dereference") errors in oauth_test. These were triggered by three
if got == nil { t.Fatal(...) }guards that staticcheck did not recognize as terminating the execution path, so it flagged subsequentgot.AccessTokenaccesses as potentially accessing a nil pointer.Replacing these three guards with
require.NotNil(t, got, ...)from testify removes the explicit nil comparison that trips staticcheck, while preserving the same fail-fast behavior and readability. The require helper is already in use throughout the test file.Tests and linter pass locally.