Conversation
|
@cpuguy83 I like the feature, I'll review in a bit. |
|
Thanks, Brian! Very welcome feature. |
daemon/delete.go
Outdated
There was a problem hiding this comment.
can you please us the string we send to the daemon instead of the container name ?
|
LGTM besides my comment |
|
@vieux Fixed. Didn't even realize! |
|
LGTM |
|
@shykes this one is for you please review |
|
Doc LGTM |
fe038be to
d10ce4b
Compare
|
Merge +1 |
|
Can you please stop assigning issues to others. Thanks. On Saturday, August 30, 2014, Frank Lemanschik notifications@github.com
|
daemon/delete.go
Outdated
There was a problem hiding this comment.
no need for double space between pinned. and You.
|
@cpuguy83 API docs need to be relocated to the 1.15 API section |
docs/man/docker-run.1.md
Outdated
d10ce4b to
a4dd003
Compare
|
Updated and rebased, PTAL |
docs/sources/reference/run.md
Outdated
There was a problem hiding this comment.
Is this commandline a stray?
There was a problem hiding this comment.
I think I must have copied the pattern from the doc underneath this one.
I'll remove
a4dd003 to
d08431c
Compare
|
Docs LGTM |
Makes it so you can pass `--pin` to `docker run` so that you can't `docekr rm` that container without also using `--force` For example: ``` docker run -d -v /myData --pin --name my_data tianon/true docker stop my_data # This isn't running, but for showcasing this, stop it docker rm my_data # this will fail even though it's not running docker rm --force my_data # this will work ``` Docker-DCO-1.1-Signed-off-by: Brian Goff <cpuguy83@gmail.com> (github: cpuguy83)
d08431c to
f93d8e5
Compare
|
@cpuguy83 sorry for the late feedback. I agree that we need better ways to mark containers as "special". For example in my case, after a host reboot I have trouble remembering which containers are "active" but just not running at the moment, vs. old stuff I just didn't get around to removing. So in a way I need the equivalent of "stars" in gmail. But this feels very specific, I would prefer to find a more generic solution to the problem of "I need to organize my containers, and distinguish the important ones from the non-important ones". Maybe some people want multiple levels of importance for example. So, I would prefer to focus on generic labels, which you could use to annotate your container in any way you want. For example anybody could experiment with a "pinning" system with something like: Over time we could promote official usage patterns by defining reserved label names. Consider this a request for implementation :) In the meantime I'm going to close this one, sorry. |
Addresses #7017
Makes it so you can pass
--pintodocker runso that you can'tdocker rmthat container without also using--forceFor example:
Docker-DCO-1.1-Signed-off-by: Brian Goff cpuguy83@gmail.com (github: cpuguy83)