Setting the mirror with mirror address.#28827
Closed
Hyzhou wants to merge 1 commit intomoby:masterfrom
Closed
Conversation
Signed-off-by: hyzhou.zhy <hyzhou.zhy@alibaba-inc.com>
Member
|
/cc @tianon |
Member
|
I'm not sure we should change this to allow any arbitrary URL to be set; also this change would break https://github.com/Azure/azure-docker-extension/blob/0539b864cc6fd64ba1236a60443c006019eb7f10/op-enable.go#L49-L51 |
|
Beside what @thaJeztah mentioned, I guess we shouldn't assume all mirrors are ending with |
Member
|
Agreed, I'm more partial to our script supporting an explicit set of "official" mirrors than simply allowing arbitrary mirrors. 👍 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
We can use the mirror address to setting the mirror. Only comply with the rules of url.
Because some user initialize the machine in Aliyun VPC environment And he can use the intranet mirror
http://mirrors.aliyuncs.com/docker-engine.By the way, if we add the option AliyunMirror or AliyunVPCMirror. More and more option will be added.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: hyzhou.zhy hyzhou.zhy@alibaba-inc.com