hmm weird errors... need to investigate why...

the windows side is because i need to update those servers

Is this still needed? https://github.com/docker/docker/blob/master/hack/dind#L14

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll still be needed on older Docker versions, but making it do the mounting nonsense conditionally based on whether we've already got it all mounted seems really sane. 👍 (ie, if ! mountpoint -q /sys/fs/cgroup; then ...)

nice yeah

On Fri, Aug 21, 2015 at 10:23 AM, Tianon Gravi notifications@github.com
wrote:

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll
still be needed on older Docker versions, but making it do the mounting
nonsense conditionally based on whether we've already got it all mounted
seems really sane. [image: 👍](ie, if ! mountpoint -q /sys/fs/cgroup;
then ...)

—
Reply to this email directly or view it on GitHub
#15596 (comment).

LGTM 🤘

(much easier to review via https://github.com/docker/docker/pull/15596/files?w=1 now)