Conversation
4c7932e to
4c786c0
Compare
|
LGTM |
daemon/daemon.go
Outdated
There was a problem hiding this comment.
@jhowardmsft why this change? I actually prefer the way it was :S
There was a problem hiding this comment.
I agree, but there's a good reason. When I split out the Container structure into common and platform specific parts, everything is good in go except for the constructor "container:=&Container{field: value, etc}.". Accessors are fine, but the constructor will fail compilation. Hence the need to rework it to be field by field. Sucks, I know. As far as I can tell, it's a limitation in go.
There was a problem hiding this comment.
Ohhh I see, what you need is this:
container := &Container{
CommonContainer: CommonContainer{
State: NewState(),
},
root: daemon.containerRoot(id),
execCommands: newExecStore(),
}
There was a problem hiding this comment.
Ahhhh, lightbulb moment. That makes sense. I just learnt more about go. Will verify and address in the morning, Thanks!
There was a problem hiding this comment.
That's fixed. Thanks for the pointer in the right direction :)
9b02025 to
5a27719
Compare
|
@tiborvass Fixed constructors. Thanks for the pointer to the right syntax. |
|
@jhowardmsft awfully sorry but needs a rebase |
5a27719 to
ccdac75
Compare
|
Rebased |
|
ah so sorry needs rebase |
|
you can ping me after :) |
|
Again??! Wow, things change fast around here :) |
ccdac75 to
1383510
Compare
|
Rebased |
d078347 to
25049b6
Compare
3effc23 to
cacf90c
Compare
97e9966 to
a0fe49b
Compare
There was a problem hiding this comment.
Does it mean that -v something:ro will be unsupported on Windows?
There was a problem hiding this comment.
For the initial release, yes that is the current plan.
|
@jhowardmsft Sorry, this requires rebasing again. |
de1453f to
d38055d
Compare
|
@unclejack Rebased. Waiting for Jenkins to complete. |
42ac3fb to
973504d
Compare
Signed-off-by: John Howard <jhoward@microsoft.com>
973504d to
b9e4b95
Compare
|
LGTM |
Signed-off-by: John Howard jhoward@microsoft.com
@swernli
This PR is part of the proposal described in issue 10662 to port the docker daemon to Windows. This PR is one of the more complex PRs unfortunately, but many future PRs will depend on this PR, so hopefully this one can be merged relatively quickly :) This PR is the first step at forking container.go into Linux and Windows versions. In doing that, it also required forking volumes.go to get compilation and integration tests to succeed, so I have also pulled in some minor changes which were slated for future PRs too in volumes. Note that container_windows.go still contains TODOs which will be addressed in future PRs which depend on this PR (didn't want to make a huge PR affecting dozens of files).
(Rebased 4/30 after engine removed)