Skip to content

don't fail when trying to remove an orphan container during down command#9896

Merged
ndeloof merged 2 commits intodocker:v2from
glours:dont-failed-when-orphan-missing
Oct 6, 2022
Merged

don't fail when trying to remove an orphan container during down command#9896
ndeloof merged 2 commits intodocker:v2from
glours:dont-failed-when-orphan-missing

Conversation

@glours
Copy link
Contributor

@glours glours commented Oct 6, 2022

What I did
Currently the down process stop when it tries to remove an orphan container that already have been removed.
Now we don't stop the process if such kind of containers is already gone.

Related issue
Reported internally by the extension team

(not mandatory) A picture of a cute animal, if possible in relation with what you did
image

@glours glours marked this pull request as ready for review October 6, 2022 14:32
@glours glours self-assigned this Oct 6, 2022
@glours glours requested review from a team, StefanScherer, benja-M-1, laurazard, milas, ndeloof, nicksieger and ulyssessouza and removed request for a team October 6, 2022 14:32
@ndeloof ndeloof enabled auto-merge (rebase) October 6, 2022 14:34
Copy link
Member

@benja-M-1 benja-M-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves the problem I spotted on my end 👍 Thanks @glours

@ndeloof ndeloof merged commit b6b58d2 into docker:v2 Oct 6, 2022
@glours glours deleted the dont-failed-when-orphan-missing branch January 11, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants