Skip to content

Don't wait for disabled dependency#9759

Merged
nicksieger merged 2 commits intodocker:v2from
nicksieger:issue-9591
Aug 17, 2022
Merged

Don't wait for disabled dependency#9759
nicksieger merged 2 commits intodocker:v2from
nicksieger:issue-9591

Conversation

@nicksieger
Copy link
Member

What I did

Check but don't wait for disabled dependency.

  • create: pull all services logic out of loop; add DependsOn deps
  • up/start/run: don't wait for disabled service

Related issue

Fixes #9591.

(not mandatory) A picture of a cute animal, if possible in relation with what you did

Parrots

Signed-off-by: Nick Sieger <nick@nicksieger.com>
Signed-off-by: Nick Sieger <nick@nicksieger.com>
@nicksieger nicksieger requested a review from a team August 17, 2022 17:36
@nicksieger nicksieger enabled auto-merge August 17, 2022 17:56
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicksieger nicksieger merged commit a64a5a6 into docker:v2 Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

up with --no-deps flag leads to no such service errors for dependent services when using condition: service_healthy

2 participants