lint: add nolintlint and clean up nolint directives#9738
Merged
Conversation
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
nolintlint and clean up nolint directives
thaJeztah
reviewed
Aug 9, 2022
| - lll | ||
| - misspell | ||
| - nakedret | ||
| - nolintlint |
Member
There was a problem hiding this comment.
Oh! Didn't know about this linter; looks handy. Perhaps I should enable it one some other repositories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
We had some incorrectly formatted and/or ineffective
nolintdirectives hanging around. I addednolintlintto the list of linters, fixed up some violations it flagged, and did some creative finds to look for some other weird/pointless ones (but spent about 5 mins on this, so it's not exhaustive).Thanks to @thaJeztah for pointing this out @ #9728 (review)
Related issue
N/A
(not mandatory) A picture of a cute animal, if possible in relation with what you did
