Conversation
fa743a3 to
6401f0d
Compare
thaJeztah
reviewed
Aug 4, 2022
Member
thaJeztah
left a comment
There was a problem hiding this comment.
Don't think this is the right fix (see my comment)
cd63858 to
4bd6c61
Compare
thaJeztah
reviewed
Aug 4, 2022
478b6ce to
7ac17c3
Compare
thaJeztah
approved these changes
Aug 4, 2022
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (assuming green)
We should probably have a test for this (as a follow-up?)
7ac17c3 to
2fe6e4b
Compare
Member
Odd failures in CI during linting; I see we're not pinning golang-ci-lint to a version, which may mean it's not compatible with the go version we're using 🤔 |
Member
|
unrelated; looks like CI is using a pretty old version of docker 20.10; https://github.com/docker/compose/blob/v2/.github/workflows/ci.yml#L104 |
e0929e5 to
b79b293
Compare
… service configuration Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
b79b293 to
c47079e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Don't override service pull policy if the value from the command line is the default one
Related issue
fix #9717
(not mandatory) A picture of a cute animal, if possible in relation with what you did
