don't remove external volumes/networks#9281
Merged
Conversation
ee67ac9 to
a3006e2
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
a3006e2 to
e7f5459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
fix
down -vso we do no removeexternalvolumes and networksthis also uses the project (when passed by command line) as source for volumes/network to be removed, vs the actual state, so that one can enforce
downwill only remove the resources listed in the compose.yaml fileRelated issue
closes #9172
(not mandatory) A picture of a cute animal, if possible in relation with what you did