recreate container after image has been rebuilt/pulled#9261
Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
abe0c69 to
85a4d04
Compare
|
Thank you for the fix and your work! Just FYI, Plextrac solution is using docker and we had to revert back docker-compose to v2.2.x to get the new instance management script working again. The update procedure was git pulling the updates but no longer recreating the containers to use the updates. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix service being re-created after image is rebuilt (
docker compose up --build)This also includes an improvement to set com.docker.compose.image to image ID when image exists in local store, so we can detect image tag been pulled with a refreshed content
Related issue
closes #9259
(not mandatory) A picture of a cute animal, if possible in relation with what you did