Merged
Conversation
This is to avoid a release error: https://github.com/docker/compose/runs/4701103662?check_suite_focus=true Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
Member
|
This related to buger/goterm#39 / buger/goterm#41 ? |
Contributor
Author
|
@thaJeztah Yes. I can transform that into a bump to |
Member
|
(I pinged the maintainer on that PR 🤞 hopefully we'll be able to bump to v1.0.4 soon then) Curious; do you know why cross build is disabled in CI? I guess that could've caught this problem? |
Contributor
Author
|
@thaJeztah The cross build is called in the release |
Contributor
|
IIRC it was disabled as it had significant impact on build time for PRs, but we could use parallel GHA jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This is to avoid a release error:
https://github.com/docker/compose/runs/4701103662?check_suite_focus=true
This is the last version before the introduction of the line triggering the error