Added volume bind option SELinux label :z :Z#9073
Merged
Conversation
Added unsupported volume bind option SELinux label `:z` and `:Z` in v2. It is a regression compared to v1 written in Python. The v2 uses the compose-spec/compose-go to parse Compose YAML specification files but there was missing support for volume bind option SELinux label `:z` and `:Z` in parser. It is fixed in: - compose-spec/compose-go#213 It fixes docker#9072 References: - https://docs.docker.com/storage/bind-mounts/#configure-the-selinux-label Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
Contributor
Author
|
Waiting for review compose-spec/compose-go#213 to drop the |
Changes were merged. Updated the `replace` directive in the `go.mod` file to the latest official package. Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
Contributor
Author
|
compose-spec/compose-go#213 was merged 😄 |
Added unit tests for all uses cases. Signed-off-by: Tymoteusz Blazejczyk <tymoteusz.blazejczyk@tymonx.com>
ndeloof
approved these changes
Jan 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added unsupported volume bind option SELinux label
:zand:Zin v2.It is a regression compared to v1 written in Python.
The v2 uses the compose-spec/compose-go to parse Compose YAML
specification files but there was missing support for volume bind option
SELinux label
:zand:Zin parser. It is fixed in:References:
Related issue
It fixes #9072
(not mandatory) A picture of a cute animal, if possible in relation with what you did