Skip to content

Remove intermediate containers when build succeeded in classic build#9012

Merged
ulyssessouza merged 2 commits intodocker:v2from
notok:rm_containers_when_build_succeed
Dec 8, 2021
Merged

Remove intermediate containers when build succeeded in classic build#9012
ulyssessouza merged 2 commits intodocker:v2from
notok:rm_containers_when_build_succeed

Conversation

@notok
Copy link
Contributor

@notok notok commented Dec 7, 2021

What I did

Remove intermediate containers when build succeeded in classic build like default behavior of docker build.

Related issue

Intermediate containers remain even when build succeeded when building with classic way (i.e. not with buildkit).

The docker-compose cli accepts the option --no-rm, but it's ignored because it's deprecated option.

Intermediate containers remain even when build succeeded
when building with classic way (i.e. not with buildkit).
Remove them when build succeeded like default behavior of docker build.

Signed-off-by: notok <noto.kazufumi@gmail.com>
@ndeloof ndeloof requested a review from ulyssessouza December 8, 2021 07:14
Signed-off-by: notok <noto.kazufumi@gmail.com>
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants