compose images should list images of created containers#8990
Merged
compose images should list images of created containers#8990
compose images should list images of created containers#8990Conversation
86bac6f to
49feec4
Compare
Signed-off-by: Kevin Roy <kiniou@gmail.com>
49feec4 to
32a0e88
Compare
ndeloof
approved these changes
Dec 5, 2021
Contributor
|
nice catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Roy kiniou@gmail.com
What I did
Like in compose v1, the
imagessub-command should list images of created services instead of just the running ones.I think this is due to the docker containers api is returning the list of running containers by default without status filters.
Therefore, we need to add
All: trueto get back the v1 behaviour according to the v1 python source code in cli/main.py wherestopped=Trueand ends inall=Truein project.py.Related issue
closes #8806