Enable bootloader_ignore_signals in pyinstaller#6578
Merged
chris-crone merged 1 commit intodocker:masterfrom Mar 15, 2019
Merged
Enable bootloader_ignore_signals in pyinstaller#6578chris-crone merged 1 commit intodocker:masterfrom
chris-crone merged 1 commit intodocker:masterfrom
Conversation
|
Please sign your commits following these rules: $ git clone -b "bootloader-ignore-signals" git@github.com:bfirsh/fig.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Fixes docker#3347 Signed-off-by: Ben Firshman <ben@firshman.co.uk>
b7b67ec to
0863785
Compare
Member
|
Quick smoke test on my machine appears to work. We'll put this out as part of 1.24 RC2 to make sure it doesn't have any unintended consequences. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋
This probably fixes Ctrl-C not working, as described in #3347. It seems like I now have to run a pretty invasive script to build an OS X binary, which I am not willing to do on my machine. Somebody might want to test this actually fixes the issue.
Fixes #3347