Skip to content

Ignore NotFound for external overlay networks#5836

Merged
shin- merged 1 commit intomasterfrom
4399-overlay-ensure
Mar 29, 2018
Merged

Ignore NotFound for external overlay networks#5836
shin- merged 1 commit intomasterfrom
4399-overlay-ensure

Conversation

@shin-
Copy link
Copy Markdown

@shin- shin- commented Mar 28, 2018

Fixes #4399
Fixes #4601

Note: If the network indeed does not exist, the error will be raised later when trying to create a container that uses it.

$ docker-compose up
WARNING: The Docker Engine you're using is running in swarm mode.
[...]
Creating repro4399_abc_1 ... error

ERROR: for repro4399_abc_1  Cannot start service abc: Could not attach to network foo: rpc error: code = NotFound desc = network foo not found

ERROR: for abc  Cannot start service abc: Could not attach to network foo: rpc error: code = NotFound desc = network foo not found
ERROR: Encountered errors while bringing up the project.

@shin-
Ignore NotFound for external overlay networks
344003a 
Signed-off-by: Joffrey F <joffrey@docker.com>
@shin- shin- added this to the 1.21.0 milestone Mar 28, 2018
@shin- shin- merged commit 1e9a66c into master Mar 29, 2018
@zhim
Copy link
Copy Markdown

zhim commented Aug 13, 2018

it is still not solve。you test in the test script。but the docker-compose command can't run also。

@shin-
Copy link
Copy Markdown
Author

shin- commented Aug 13, 2018

@zhim see: #4601 (comment)

@shin- shin- deleted the 4399-overlay-ensure branch October 4, 2018 09:44
@ompugao
Copy link
Copy Markdown

ompugao commented Oct 17, 2019

this problem is not solved yet. even if I specify version: '2,3' or version: '3.3', the same problem occurs.

ERROR: Network XXX declared as external, but could not be found. Please create the network manually using `docker network create XXX` and try again.

version info:

$ docker-compose version
docker-compose version 1.24.1, build 4667896b
docker-py version: 3.7.3
CPython version: 3.6.8
OpenSSL version: OpenSSL 1.1.0j  20 Nov 2018
$ docker version
Client: Docker Engine - Community
 Version:           19.03.3
 API version:       1.40
 Go version:        go1.12.10
 Git commit:        a872fc2f86
 Built:             Tue Oct  8 00:59:59 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server: Docker Engine - Community
 Engine:
  Version:          19.03.3
  API version:      1.40 (minimum version 1.12)
  Go version:       go1.12.10
  Git commit:       a872fc2f86
  Built:            Tue Oct  8 00:58:31 2019
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.2.10
  GitCommit:        b34a5c8af56e510852c35414db4c1f4fa6172339
 runc:
  Version:          1.0.0-rc8+dev
  GitCommit:        3e425f80a8c931f88e6d94a8c831b9d5aa481657
 docker-init:
  Version:          0.18.0
  GitCommit:        fec3683

@ompugao
Copy link
Copy Markdown

ompugao commented Oct 17, 2019

this is because self.driver is None

@ompugao
Copy link
Copy Markdown

ompugao commented Oct 17, 2019

oops, by specifying its driver, it works. I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.21.0

Development

Successfully merging this pull request may close these issues.

Swarm network can't use in docker-compose.yml Overlay network not found on worker node

3 participants

@shin- @zhim @ompugao