Skip to content

Search .env file in parent directories#5238

Closed
hennevogel wants to merge 1 commit intodocker:masterfrom
hennevogel:feature/relative-env
Closed

Search .env file in parent directories#5238
hennevogel wants to merge 1 commit intodocker:masterfrom
hennevogel:feature/relative-env

Conversation

@hennevogel
Copy link

Extracts the methods responsible for this into their own module and uses this
module for searching yml and .env files. This follows the same rules as the yml
files.

So you can have base_dir/.env and no project_dir/.env or project_dir/.env.
Before .env file was only used if you invoke from the base directory.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "feature/relative-env" git@github.com:hennevogel/compose.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Extracts the methods responsible for this into their own module and uses this
module for searching yml and .env files. This follows the same rules as the yml
files.

So you can have base_dir/.env and no project_dir/.env or project_dir/.env.
Before .env file was only used if you invoke from the base directory.

Signed-off-by: Hendrik Vogelsang <hvogel@opensuse.org>
@hennevogel
Copy link
Author

Not sure this warrants a new test as this whole .env file feature is basically untested...

@hennevogel
Copy link
Author

Also not sure what jenkins want's to tell me. Maybe someone can translate? 🤠

@ulyssessouza
Copy link
Contributor

Stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants