docker-compose exec doesn't have -e option (fixes #4551)#5237
Merged
shin- merged 1 commit intodocker:masterfrom Oct 25, 2017
Merged
docker-compose exec doesn't have -e option (fixes #4551)#5237shin- merged 1 commit intodocker:masterfrom
shin- merged 1 commit intodocker:masterfrom
Conversation
c901db6 to
20e9bb9
Compare
shin-
suggested changes
Oct 19, 2017
shin-
left a comment
There was a problem hiding this comment.
A couple of small modifications, looks good overall.
| } | ||
|
|
||
| # setting environment for exec is not supported in API < 1.25' | ||
| if docker.utils.version_gte(self.project.client.api_version, '1.25'): |
There was a problem hiding this comment.
We should call out that limitation in the docstring above, and raise a UserError if the API version is too low.
tests/acceptance/cli_test.py
Outdated
| ]) | ||
|
|
||
| # env overridden | ||
| self.assertIn('foo=notbar', stdout) |
There was a problem hiding this comment.
nit: we can use assert 'foo=notbar' in stdout instead (and similarly for the lines below), which looks a bit nicer.
20e9bb9 to
acc55b6
Compare
Signed-off-by: Guillermo Arribas <garribas@gmail.com>
acc55b6 to
968cd11
Compare
Author
|
Thanks for the feedback, made requested changes. |
shin-
approved these changes
Oct 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillermo Arribas garribas@gmail.com
Had to refactor a little bit method TopLevelCommand.exec_command to reduce cyclomatic complexity and avoid pre commit hooks error.