Skip to content

[Addresses 12236]: docker compose --watch doesn't properly handle .dockerignore whitelists #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mvhatch wants to merge 2 commits into from
Closed

[Addresses 12236]: docker compose --watch doesn't properly handle .dockerignore whitelists #12238

mvhatch wants to merge 2 commits into from

Conversation

@mvhatch
Copy link

@mvhatch mvhatch commented Oct 26, 2024 •
edited
Loading

  1. make build
  2. cd bug-12236
  3. ../bin/build/docker-compose -D up --watch alpine

Expected Output:

  1. Debug logs show that docker compose copies 1 file for initial sync.
  2. Docker compose copies./dir1 from the host machine to /app/dir1 in the created container.
  3. The ls -la output shows dir1.

Actual Output:

✗ ../bin/build/docker-compose -D up --watch alpine
[+] Running 1/0
 ✔ Container bug-12236-alpine-1  Created                                                                                                                                       0.0s 
Attaching to alpine-1
DEBU[0000] Using .dockerignore file: /Users/michaelhatch/compose/bug-12236/.dockerignore 
DEBU[0000] ignoring file /Users/michaelhatch/compose/bug-12236/dir1/foo.txt 
DEBU[0000] copying 0 files for initial sync             
alpine-1  | total 8
alpine-1  | drwxr-xr-x    2 root     root          4096 Oct 26 17:11 .
alpine-1  | drwxr-xr-x    1 root     root          4096 Oct 26 17:34 ..
DEBU[0000] Watch configuration for service "alpine":
  - Action sync+restart for path "/Users/michaelhatch/compose/bug-12236/dir1" 
          ⦿ Watch enabled
alpine-1 exited with code 0
          ⦿ Watch disabled

Related Issue

See issue here.

@mvhatch mvhatch mentioned this pull request Oct 26, 2024
Closed
@idsulik idsulik mentioned this pull request Oct 27, 2024
Merged
@glours
Copy link
Contributor

glours commented Oct 28, 2024

PR #12239 merged

@glours glours closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mvhatch @glours