Skip to content

use compose-go version fixing extra_hosts unicity issue#12159

Merged
jhrotko merged 1 commit intodocker:mainfrom
glours:fix-extra_hosts_unicity-issue
Sep 26, 2024
Merged

use compose-go version fixing extra_hosts unicity issue#12159
jhrotko merged 1 commit intodocker:mainfrom
glours:fix-extra_hosts_unicity-issue

Conversation

@glours
Copy link
Copy Markdown
Contributor

@glours glours commented Sep 24, 2024

What I did
Bump compose-go version fixing extra_hosts unicity issue

Related issue
fixes #12155

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@glours glours self-assigned this Sep 24, 2024
@glours glours requested review from a team, jhrotko and ndeloof and removed request for a team September 24, 2024 13:01
go.mod Outdated
tags.cncf.io/container-device-interface v0.8.0 // indirect
)

replace github.com/compose-spec/compose-go/v2 => github.com/glours/compose-go/v2 v2.0.0-20240924124937-38f94a79402c
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to test again Compose CI until we release a new version of compose-go

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked the PR as draft for now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I got confused for this reason as I got notified on this one first :)

@glours glours marked this pull request as draft September 24, 2024 13:08
@glours glours force-pushed the fix-extra_hosts_unicity-issue branch 2 times, most recently from 697c12b to 2ba208e Compare September 26, 2024 09:32
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the fix-extra_hosts_unicity-issue branch from 2ba208e to 9a7a95f Compare September 26, 2024 14:14
@glours glours requested a review from ndeloof September 26, 2024 14:17
@glours glours marked this pull request as ready for review September 26, 2024 14:17
@jhrotko jhrotko merged commit c9d96b4 into docker:main Sep 26, 2024
@glours glours deleted the fix-extra_hosts_unicity-issue branch June 30, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] <extra_hosts array items[0,1] must be unique>

3 participants