build: replace uses of archive.CanonicalTarNameForPath #11910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is an alias for filepath.IsAbs and we are considering deprecating and/or removing this function in the archive package, so removing its uses helps transitioning if we decide to deprecate and/or remove it. [docker/cli@fb0788f] also added a normalize step in TrimBuildFilesFromExcludes, so that callers are not _required_ to first normalize the path, so the normalizeation may be redunant, but keeping the normalization as this variable is used further down the code. [docker/cli@fb0788f]: docker/cli@fb0788f Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is an alias for filepath.IsAbs and we are considering deprecating and/or removing this function in the archive package, so removing its uses helps transitioning if we decide to deprecate and/or remove it.
docker/cli@fb0788f also added a normalize step in TrimBuildFilesFromExcludes, so that callers are not required to first normalize the path, so the normalizeation may be redunant, but keeping the normalization as this variable is used further down the code.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did