Fix COMPOSE_PROFILES can be set by .env file #11861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
approved these changes
May 29, 2024
Contributor
glours
left a comment
There was a problem hiding this comment.
Sounds good to me, let's prepare a release of compose-go and then update the dependency in Compose repo
Contributor
Author
|
I'm fine we just use a HEAD commit reference waiting for next release |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
607dc6d to
e097de2
Compare
glours
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix COMPOSE_PROFILES can be set by .env file
relies on compose-spec/compose-go#632
test case to cover this scenario so this regression won't silently come back
fix #11856