introduce --all-resources to _not_ exclude resources not used by services#11702
Merged
ndeloof merged 2 commits intodocker:mainfrom Apr 9, 2024
Merged
introduce --all-resources to _not_ exclude resources not used by services#11702ndeloof merged 2 commits intodocker:mainfrom
--all-resources to _not_ exclude resources not used by services#11702ndeloof merged 2 commits intodocker:mainfrom
Conversation
…ices Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
milas
suggested changes
Apr 9, 2024
Contributor
milas
left a comment
There was a problem hiding this comment.
Blocking: Can we get some sort of test coverage please? 🙏🏻
Non-blocking / my opinion: Compose Up is pretty service-oriented, and this feels like a band-aid for a niche use case. If declaratively managing volumes/networks/secrets/configs independent of containers is something we really want to support, I feel like it's something that'd be better to approach more generically/as a feature.
Contributor
Author
|
@milas exclusion for resources not being used by a service was introduced by profile, before compose (v1) used to just create resources as declared in a compose file |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Contributor
Author
|
added e2e test for this new flag |
milas
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
introduce
--all-resourcesso that compose model don't get resources not used by services excludedThis allows to use
docker compose createto manage non-services resources, when such a resource is shared by multiple compose application.Related issue
closes #10930
(not mandatory) A picture of a cute animal, if possible in relation to what you did
