Ignore missing containers when compose down/stop -p#11692
Merged
ndeloof merged 3 commits intodocker:mainfrom Apr 11, 2024
Merged
Ignore missing containers when compose down/stop -p#11692ndeloof merged 3 commits intodocker:mainfrom
ndeloof merged 3 commits intodocker:mainfrom
Conversation
e900bd3 to
6392799
Compare
ndeloof
reviewed
Apr 9, 2024
pkg/compose/dependencies.go
Outdated
| // InDependencyOrder applies the function to the services of the project taking in account the dependency order | ||
| func InDependencyOrder(ctx context.Context, project *types.Project, fn func(context.Context, string) error, options ...func(*graphTraversal)) error { | ||
| graph, err := NewGraph(project, ServiceStopped) | ||
| graph, err := NewGraph(project, ServiceStopped, false) |
Contributor
There was a problem hiding this comment.
an alternative approach is to use project.WithServicesTransform to set DependsOn.Required = false on all services, s you don't need API change
Signed-off-by: koooge <koooooge@gmail.com>
Signed-off-by: koooge <koooooge@gmail.com>
Signed-off-by: koooge <koooooge@gmail.com>
6392799 to
0e58676
Compare
ndeloof
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix the error of docker compose down/stop with
-pcould not find <container>: not foundwhen there are services depend_on missing containers. The scenario is particularly likely to happen when using initial containers. docker system prune is one reason to remove init containers, for example.Related issue
fixes #11686
(not mandatory) A picture of a cute animal, if possible in relation to what you did