don't use ansi espace sequence when disabled#11682
Merged
ndeloof merged 1 commit intodocker:mainfrom Apr 3, 2024
Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11682 +/- ##
==========================================
- Coverage 54.57% 54.25% -0.33%
==========================================
Files 145 145
Lines 12605 12630 +25
==========================================
- Hits 6879 6852 -27
- Misses 5037 5086 +49
- Partials 689 692 +3 ☔ View full report in Codecov by Sentry. |
|
Can confirm that this patch will resolve #11681. Thank you! |
jhrotko
approved these changes
Apr 3, 2024
Contributor
Author
|
Let's merge this with this quick and dirty fix, will need to revisit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
when ansi is disabled or output is not a terminal, fully disable any ANSI magic
Related issue
closes #11681
(not mandatory) A picture of a cute animal, if possible in relation to what you did