don't check external network existence when swarm is enabled#11409
Merged
glours merged 1 commit intodocker:mainfrom Jan 29, 2024
Merged
don't check external network existence when swarm is enabled#11409glours merged 1 commit intodocker:mainfrom
glours merged 1 commit intodocker:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11409 +/- ##
==========================================
- Coverage 56.54% 56.54% -0.01%
==========================================
Files 136 136
Lines 11545 11542 -3
==========================================
- Hits 6528 6526 -2
Misses 4390 4390
+ Partials 627 626 -1 ☔ View full report in Codecov by Sentry. |
glours
approved these changes
Jan 29, 2024
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
84796d4 to
da1a34a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
we can't check a swarm overlay network exists until we connect a container. Asking user to declare
driver: overlayis conter-intuitive and incorrect (an external resource should have no config element declared). Better ignore and wait for connect API call to (maybe) fail and report an error to user.Related issue
fixes #11387
(not mandatory) A picture of a cute animal, if possible in relation to what you did