fix(tracing): batch span exports to prevent blocking#11364
Merged
ndeloof merged 1 commit intodocker:mainfrom Jan 17, 2024
Merged
fix(tracing): batch span exports to prevent blocking#11364ndeloof merged 1 commit intodocker:mainfrom
ndeloof merged 1 commit intodocker:mainfrom
Conversation
This was a bad configuration (my fault) that meant each span was exported synchronously, as it ended. That can cause weird behavior such as stuttering/blocking. There's really no reason to NOT use the batch processor, it's the recommended way to configure it. In the future, it might make sense to tune the intervals based on the fact that Compose is a CLI vs a long-running server app, but we handle flushing out on exit already, so it's not a huge deal. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
glours
approved these changes
Jan 17, 2024
Contributor
glours
left a comment
There was a problem hiding this comment.
Yeah!!! Glad you catch it 👍
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11364 +/- ##
==========================================
+ Coverage 56.55% 56.61% +0.06%
==========================================
Files 136 136
Lines 11541 11539 -2
==========================================
+ Hits 6527 6533 +6
+ Misses 4387 4381 -6
+ Partials 627 625 -2 ☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Jan 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This was a bad configuration (my fault) that meant each span was exported synchronously, as it ended. That can cause weird behavior such as stuttering/blocking.
There's really no reason to NOT use the batch processor, it's the recommended way to configure it. In the future, it might make sense to tune the intervals based on the fact that Compose is a CLI vs a long-running server app, but we handle flushing out on exit already, so it's not a huge deal.
Related issue
https://docker.atlassian.net/browse/COMP-387
(not mandatory) A picture of a cute animal, if possible in relation to what you did
