Stop the resource timer after last expected event#11357
Merged
ndeloof merged 1 commit intodocker:mainfrom Jan 16, 2024
Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11357 +/- ##
==========================================
- Coverage 56.74% 56.56% -0.18%
==========================================
Files 134 136 +2
Lines 11448 11541 +93
==========================================
+ Hits 6496 6528 +32
- Misses 4330 4387 +57
- Partials 622 626 +4 ☔ View full report in Codecov by Sentry. |
|
This seems to be broken again, after updating to Docker Desktop 4.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Doneevent status doesn't mean the resource reached the expected status, it typically is firstCreatedthenStartedand eventuallyHealthy. We need the TUI to be aware more events are expected and not stop the timer.Related issue
fixes #11326
(not mandatory) A picture of a cute animal, if possible in relation to what you did
