Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 13, 2023

What I did
bump compose-go to v1.20.1
implemented support for build.ulimits
implemented support for config.content (inlined config)

@ndeloof ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team November 13, 2023 18:12
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍
Just need to fix the lint issue

@codecov
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (43c3f54) 56.90% compared to head (253f4fe) 56.71%.
Report is 1 commits behind head on main.

❗ Current head 253f4fe differs from pull request most recent head 8a3e2e1. Consider uploading reports for the commit 8a3e2e1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11187      +/-   ##
==========================================
- Coverage   56.90%   56.71%   -0.19%     
==========================================
  Files         133      133              
  Lines       11370    11427      +57     
==========================================
+ Hits         6470     6481      +11     
- Misses       4274     4308      +34     
- Partials      626      638      +12     
Files Coverage Δ
pkg/compose/convergence.go 70.59% <25.00%> (-0.33%) ⬇️
pkg/compose/build.go 76.84% <36.36%> (-1.21%) ⬇️
pkg/compose/secrets.go 62.50% <64.00%> (-0.58%) ⬇️
pkg/compose/create.go 58.00% <36.36%> (-0.43%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants