Merged
Conversation
Signed-off-by: Matthew Walowski <mattwalowski@gmail.com>
1d562dc to
bf26515
Compare
glours
approved these changes
Oct 27, 2023
Contributor
glours
left a comment
There was a problem hiding this comment.
LTGM, tests ok with --hash=* or --hash=serviceA,serviceB
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11146 +/- ##
==========================================
- Coverage 57.46% 57.44% -0.03%
==========================================
Files 129 129
Lines 11285 11288 +3
==========================================
- Hits 6485 6484 -1
- Misses 4170 4174 +4
Partials 630 630
☔ View full report in Codecov by Sentry. |
ndeloof
approved these changes
Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When I previously changed the hashing behavior in #11010, I neglected to consider the case where someone provides
--hash=*todocker configure. My code assumed that a service name would always be passed in explicitly. This change uses all project service names in the absence of any provided name .Related issue
Fixes #11145, thanks for pointing this out!