fix SIGTERM support to stop/kill stack#11127
Merged
ndeloof merged 1 commit intodocker:mainfrom Oct 26, 2023
Merged
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11127 +/- ##
==========================================
- Coverage 57.54% 57.39% -0.15%
==========================================
Files 129 129
Lines 11272 11285 +13
==========================================
- Hits 6486 6477 -9
- Misses 4156 4177 +21
- Partials 630 631 +1
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
this fix signal management:
A dedicated goroutine is set to handle signal and trigger stop/kill commands (first signal will stop, the next one kills).
doneChis set to stop this goroutine when no sigterm signal is caught. It's not actually used as a channel, just as a way forselectto react as channel is closed and stop the goroutineisTerminatedboolean let us know stack was terminated anddoneChdoesn't need to be closed. It is set oncestopsucceed, so that it in the meantime we can capture subsequent SIGTERM and kill the stack.Note: this works well when ran by
~/.docker/cli-plugins/docker-compose uporcom.docker.cli compose upbut when used with cloud integrations which forwards signals (😓) we receive duplicated SIGTERM signals and go runtime kills compose plugin after 3rd oneRelated issue
closes #11123
(not mandatory) A picture of a cute animal, if possible in relation to what you did