align with OCI artifact best practices#11120
Conversation
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
|
I don't think that page ORAS represents best practices; in particular there is no need to use a layer tar mediaType when that is not actually the format of the data. It's worth noting that they also show a custom layer mediaType in their "with config" example -- I suspect the overloading of the layer mediaType is merely an error in updating the page. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11120 +/- ##
==========================================
- Coverage 57.54% 57.44% -0.10%
==========================================
Files 129 129
Lines 11272 11276 +4
==========================================
- Hits 6486 6478 -8
- Misses 4156 4166 +10
- Partials 630 632 +2
☔ View full report in Codecov by Sentry. |
|
@neersighted right, would you recommend a better "source of truth" ? I hardly can find documentation on OCI artifacts, Google 1st result being archived https://github.com/opencontainers/artifacts 😅 |
|
https://github.com/opencontainers/image-spec/blob/main/manifest.md#guidelines-for-artifact-usage I'm also working on trying to make more of this obvious in the spec, e.g. at opencontainers/image-spec#1141. Reviews of that PR/suggestions for further content or structure improvements are welcome. |
|
Oh! And if I wasn't clear -- I think it's still worth carrying the annotation change; just not the change to the layer mediaType. |
|
sure, I plan to update this PR with a few other fixes, so making this one a draft |
|
"reopen" action failing, will create another one 😅 |
What I did
better align with OCI artifact best practices (https://oras.land/docs/concepts/artifact/):
application/vnd.oci.image.layer.v1.tarorg.opencontainers.image.createdannotation is set(not mandatory) A picture of a cute animal, if possible in relation to what you did