fix(secrets): file permission value does not comply with spec#10784
Merged
fix(secrets): file permission value does not comply with spec#10784
Conversation
closes docker#10783 Compose Spec mentions that default values for secrets is `0444` aka. world-readable permissions. However, the value was previously set to `0400`. Signed-off-by: Shan Desai <shantanoo.desai@gmail.com>
glours
approved these changes
Jul 10, 2023
ndeloof
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose Spec mentions that default values for secrets is
0444aka. world-readable permissions. However, the value was previously set to0400.What I did
Fix the file permission mode value from previously set
0400to0444in order to comply with the Compose Specifications where Secrets should be defaulted to world-readable permissions unless not explicitly mentioned via Long Syntax.Related issue
closes #10783
(not mandatory) A picture of a cute animal, if possible in relation to what you did