Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10742 +/- ##
==========================================
+ Coverage 59.03% 59.11% +0.07%
==========================================
Files 113 115 +2
Lines 9774 9844 +70
==========================================
+ Hits 5770 5819 +49
- Misses 3419 3435 +16
- Partials 585 590 +5
☔ View full report in Codecov by Sentry. |
83e832b to
57efbea
Compare
Member
|
One more thing, what do you think about adding a e2e or cuke test? |
ndeloof
reviewed
Jun 29, 2023
Contributor
|
this new command deserves an e2e tests (says the guy who never writes tests :P) |
Contributor
Author
|
@ndeloof @nicksieger The idea was to validate the concept first (that's the reason the draft). I'll write the tests now. |
ulyssessouza
commented
Jun 30, 2023
| }, | ||
| } | ||
|
|
||
| cmd.Flags().BoolVar(&opts.downProject, "down-project", false, "Drops project when the first container stops") |
Contributor
Author
There was a problem hiding this comment.
For now I just added this --down-project. But I can imagine having a stop-project or stop-services, only stopping the services we enumerated in the wait
bb1d8a2 to
2ba1ed5
Compare
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ndeloof
approved these changes
Jun 30, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add
waitcommandRelated issue
Resolves #10395
(not mandatory) A picture of a cute animal, if possible in relation to what you did
