Fix concurrent map read/write when recreating containers#10379
Merged
Fix concurrent map read/write when recreating containers#10379
Conversation
Signed-off-by: Luis Rascao <luis.rascao@gmail.com>
89410f0 to
ed64163
Compare
lrascao
commented
Mar 17, 2023
| } | ||
| name := getContainerName(project.Name, service, number) | ||
| tmpName := fmt.Sprintf("%s_%s", replaced.ID[:12], name) | ||
| service.CustomLabels[api.ContainerReplaceLabel] = replaced.ID |
Contributor
Author
There was a problem hiding this comment.
this was the offending write
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10379 +/- ##
==========================================
+ Coverage 53.39% 53.41% +0.01%
==========================================
Files 104 104
Lines 8939 8942 +3
==========================================
+ Hits 4773 4776 +3
Misses 3646 3646
Partials 520 520
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why i did it
docker-compose.yamldocker-compose -f docker-compose.yaml up --force-recreate --scale agent=500fatal error: concurrent map iteration and map writeWhat I did
For each container, the
CustomLabelsmap was being filled out and used as a way to pass labels to lower levels of the stack while being concurrently read by other goroutines in the process of spinning other containers. A newlabelsargument was added and propagated down the stack thus avoiding the need to set the map.Related issue
fixes #10319
I love it when a plan comes together