progress writer uses dockercli.Err stream#10366
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10366 +/- ##
==========================================
+ Coverage 53.32% 53.36% +0.03%
==========================================
Files 104 104
Lines 8911 8911
==========================================
+ Hits 4752 4755 +3
+ Misses 3640 3638 -2
+ Partials 519 518 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
4fb44d2 to
46b686d
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
46b686d to
7731644
Compare
milas
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Pass
dockerCli.Err()toNewWriterso it uses relevant streams vsos.Stderrbenefits doing so is that it helps configure and capture output on e2e tests
(not mandatory) A picture of a cute animal, if possible in relation to what you did
