Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10343 +/- ##
===========================================
- Coverage 74.18% 53.47% -20.71%
===========================================
Files 2 104 +102
Lines 275 8927 +8652
===========================================
+ Hits 204 4774 +4570
- Misses 60 3635 +3575
- Partials 11 518 +507
... and 88 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
glours
approved these changes
Mar 8, 2023
Contributor
glours
left a comment
There was a problem hiding this comment.
LGTM, we just need to release compose-go to get this PR merged
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
0364392 to
d0b81a8
Compare
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
illustrate support for inlined dockerfile as proposed by compose-spec/compose-spec#298
Related issue
closes #8077
(not mandatory) A picture of a cute animal, if possible in relation to what you did
