Skip to content

adopt http://no-color.org/#10342

Merged
ndeloof merged 1 commit intodocker:v2from
ndeloof:NO_COLOR
Mar 3, 2023
Merged

adopt http://no-color.org/#10342
ndeloof merged 1 commit intodocker:v2from
ndeloof:NO_COLOR

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Mar 3, 2023

What I did
add support for NO_COLOR env var according to http://no-color.org/

Related issue
closes #10340

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, StefanScherer, glours, laurazard, milas, nicksieger and ulyssessouza and removed request for a team March 3, 2023 09:46
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a84345b) 74.18% compared to head (984a861) 74.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10342   +/-   ##
=======================================
  Coverage   74.18%   74.18%           
=======================================
  Files           2        2           
  Lines         275      275           
=======================================
  Hits          204      204           
  Misses         60       60           
  Partials       11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full support for NO_COLOR

3 participants