restart only needed services by checking depends_on relations#10338
Merged
restart only needed services by checking depends_on relations#10338
Conversation
ndeloof
reviewed
Mar 1, 2023
4edff17 to
0a5ece7
Compare
ndeloof
approved these changes
Mar 1, 2023
ndeloof
approved these changes
Mar 1, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## v2 #10338 +/- ##
=======================================
Coverage 74.18% 74.18%
=======================================
Files 2 2
Lines 275 275
=======================================
Hits 204 204
Misses 60 60
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
0a5ece7 to
3cfbac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the issue that restarted all services without taking care of cli's params nor dependent services with an explicit restart option.
Related issue
closes #10337
Link to https://docker.atlassian.net/browse/ENV-65
(not mandatory) A picture of a cute animal, if possible in relation to what you did
